Re: [PATCH] inet: add bound ports statistic

2018-03-01 Thread Eric Dumazet
On Thu, 2018-03-01 at 08:16 -0800, Stephen Hemminger wrote: > > I went through a several possible alternatives. >1. Add a counter in the hash bucket head (like listen already has). > But not namespace aware >2. Add a percpu counter in network namespace (new struct tcp_netns) >

Re: [PATCH] inet: add bound ports statistic

2018-03-01 Thread Stephen Hemminger
On Wed, 28 Feb 2018 20:28:15 -0800 Eric Dumazet wrote: > On Wed, 2018-02-28 at 22:32 -0500, David Miller wrote: > > From: Eric Dumazet > > Date: Wed, 28 Feb 2018 18:28:02 -0800 > > > > > How useful it is to report this information ? > > > > > > Given REUSEADDR and REUSEPORT, I really wonder

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread Eric Dumazet
On Wed, 2018-02-28 at 22:32 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 28 Feb 2018 18:28:02 -0800 > > > How useful it is to report this information ? > > > > Given REUSEADDR and REUSEPORT, I really wonder what can be derived from > > this counter. > > > > It seems its semantic

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread David Miller
From: Eric Dumazet Date: Wed, 28 Feb 2018 18:28:02 -0800 > How useful it is to report this information ? > > Given REUSEADDR and REUSEPORT, I really wonder what can be derived from > this counter. > > It seems its semantic is weak. To me none of this really matters. What matters is that iprou

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread Eric Dumazet
On Wed, 2018-02-28 at 18:01 -0800, Stephen Hemminger wrote: > This adds a number of bound ports in a network namespace which is > a useful for socket summary (ss) command. It adds one additional > field onto /proc/net/sockstat. > > Since collecting these kind of counters can be sensitive for large

[PATCH] inet: add bound ports statistic

2018-02-28 Thread Stephen Hemminger
This adds a number of bound ports in a network namespace which is a useful for socket summary (ss) command. It adds one additional field onto /proc/net/sockstat. Since collecting these kind of counters can be sensitive for large machines, the impact is placed on the reading side which will be much