Re: [PATCH] improved statistics for bcm43xx-softmac

2006-06-29 Thread Larry Finger
Dan Williams wrote: To me, it looks like you're trying to use dBm rather than RSSI here. In that case, you have to set range->max_qual.level to 0, because the upper bound of dBm is indeed 0. If you are using negative values _anywhere_ in your code for quality, you're almost certainly using dBm

Re: [PATCH] improved statistics for bcm43xx-softmac

2006-06-29 Thread Dan Williams
On Wed, 2006-06-28 at 23:08 -0500, Larry Finger wrote: > This patch improves the statistics returned from bcm43xx_get_wireless_stats. > The signal level comes > from smoothing the rssi value returned by the firmware. The quality value is > a hack derived from the > smoothed rssi value and an assu

Re: [PATCH] improved statistics for bcm43xx-softmac

2006-06-29 Thread Larry Finger
Michael Buesch wrote: On Thursday 29 June 2006 06:08, Larry Finger wrote: /* fill in the real statistics when iface associated */ - wstats->qual.qual = 100; // TODO: get the real signal quality - wstats->qual.level = 3 - bcm->stats.link_quality; + list_for_each_entr

Re: [PATCH] improved statistics for bcm43xx-softmac

2006-06-29 Thread Michael Buesch
On Thursday 29 June 2006 06:08, Larry Finger wrote: > This patch improves the statistics returned from bcm43xx_get_wireless_stats. > The signal level comes > from smoothing the rssi value returned by the firmware. The quality value is > a hack derived from the > smoothed rssi value and an assumed

[PATCH] improved statistics for bcm43xx-softmac

2006-06-28 Thread Larry Finger
This patch improves the statistics returned from bcm43xx_get_wireless_stats. The signal level comes from smoothing the rssi value returned by the firmware. The quality value is a hack derived from the smoothed rssi value and an assumed rssi_max of -25. If anyone has a better value, please let m