Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-16 Thread Vicente Jiménez
On Wed, Nov 16, 2016 at 2:14 AM, Florian Westphal wrote: > Vicente Jiménez wrote: >> 1- add warning with pr_warn_ratelimited. I like this idea. I also >> though about adding some message but I have no kernel experience and I >> preferred to have just a working solution. > > I added this only to s

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Florian Westphal
Vicente Jiménez wrote: > I agree that both patches try to solve the same problem in a very similar way. > Florian Westphal's patch do two more things: > 1- add warning with pr_warn_ratelimited. I like this idea. I also > though about adding some message but I have no kernel experience and I > pref

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Vicente Jiménez
I agree that both patches try to solve the same problem in a very similar way. Florian Westphal's patch do two more things: 1- add warning with pr_warn_ratelimited. I like this idea. I also though about adding some message but I have no kernel experience and I preferred to have just a working solut

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Florian Westphal
David Miller wrote: > From: Vicente Jiménez > Date: Tue, 15 Nov 2016 17:49:43 +0100 > > > On Mon, Nov 14, 2016 at 7:36 PM, David Miller wrote: > >> From: Vicente Jimenez Aguilar > >> Date: Fri, 11 Nov 2016 21:20:18 +0100 > >> > >>> @@ -819,6 +820,12 @@ static bool icmp_unreach(struct sk_buff *

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread David Miller
From: Vicente Jiménez Date: Tue, 15 Nov 2016 17:49:43 +0100 > On Mon, Nov 14, 2016 at 7:36 PM, David Miller wrote: >> From: Vicente Jimenez Aguilar >> Date: Fri, 11 Nov 2016 21:20:18 +0100 >> >>> @@ -819,6 +820,12 @@ static bool icmp_unreach(struct sk_buff *skb) >>>

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Vicente Jiménez
On Mon, Nov 14, 2016 at 7:36 PM, David Miller wrote: > From: Vicente Jimenez Aguilar > Date: Fri, 11 Nov 2016 21:20:18 +0100 > >> @@ -819,6 +820,12 @@ static bool icmp_unreach(struct sk_buff *skb) >> /* fall through */ >> case 0: >>

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-14 Thread David Miller
From: Vicente Jimenez Aguilar Date: Fri, 11 Nov 2016 21:20:18 +0100 > @@ -819,6 +820,12 @@ static bool icmp_unreach(struct sk_buff *skb) > /* fall through */ > case 0: > info = ntohs(icmph->un.frag.mtu); > +

[PATCH] icmp: Restore resistence to abnormal messages

2016-11-11 Thread Vicente Jimenez Aguilar
Restore network resistance to abnormal ICMP fragmentation needed messages with next hop MTU equal to (or exceeding) dropped packet size Fixes: 46517008e116 ("ipv4: Kill ip_rt_frag_needed().") Signed-off-by: Vicente Jimenez Aguilar --- net/ipv4/icmp.c | 7 +++ 1 file changed, 7 insertions(+)