> To: Brandeburg, Jesse ; Jakub Kicinski
>
> Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Nguyen, Anthony
> L ; Yang, Lihong ; Laba,
> SlawomirX ; Nunley, Nicholas D
>
> Subject: Re: [PATCH] iavf: fix locking of critical sections
>
> On 16.03
, Jesse ; Jakub Kicinski
Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Nguyen, Anthony L
; Yang, Lihong ; Laba,
SlawomirX ; Nunley, Nicholas D
Subject: Re: [PATCH] iavf: fix locking of critical sections
On 16.03.21 23:02, Jesse Brandeburg wrote:
> Jakub Kicinski wrote:
>
On 16.03.21 23:02, Jesse Brandeburg wrote:
> Jakub Kicinski wrote:
I personally think that the overuse of flags in Intel drivers brings
nothing but trouble. At which point does it make sense to just add a
lock / semaphore here rather than open code all this with no clear
semanti
Jakub Kicinski wrote:
> > > I personally think that the overuse of flags in Intel drivers brings
> > > nothing but trouble. At which point does it make sense to just add a
> > > lock / semaphore here rather than open code all this with no clear
> > > semantics? No code seems to just test the __IAVF
On Tue, 16 Mar 2021 18:27:10 +0100 Stefan Assmann wrote:
> On 16.03.21 18:14, Jakub Kicinski wrote:
> > On Tue, 16 Mar 2021 11:01:41 +0100 Stefan Assmann wrote:
> >> To avoid races between iavf_init_task(), iavf_reset_task(),
> >> iavf_watchdog_task(), iavf_adminq_task() as well as the shutdown a
On 16.03.21 18:14, Jakub Kicinski wrote:
> On Tue, 16 Mar 2021 11:01:41 +0100 Stefan Assmann wrote:
>> To avoid races between iavf_init_task(), iavf_reset_task(),
>> iavf_watchdog_task(), iavf_adminq_task() as well as the shutdown and
>> remove functions more locking is required.
>> The current pro
On Tue, 16 Mar 2021 11:01:41 +0100 Stefan Assmann wrote:
> To avoid races between iavf_init_task(), iavf_reset_task(),
> iavf_watchdog_task(), iavf_adminq_task() as well as the shutdown and
> remove functions more locking is required.
> The current protection by __IAVF_IN_CRITICAL_TASK is needed in
To avoid races between iavf_init_task(), iavf_reset_task(),
iavf_watchdog_task(), iavf_adminq_task() as well as the shutdown and
remove functions more locking is required.
The current protection by __IAVF_IN_CRITICAL_TASK is needed in
additional places.
- The reset task performs state transitions,
