Re: [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

2017-12-13 Thread David Miller
From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:49:52 +0800 > The driver may sleep under a spinlock. > The function call path is: > rr_close (acquire the spinlock) > free_irq --> may sleep > > To fix it, free_irq is moved to the place without holding the spinlock. > > This bug is found by my stati

[PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

2017-12-12 Thread Jia-Ju Bai
The driver may sleep under a spinlock. The function call path is: rr_close (acquire the spinlock) free_irq --> may sleep To fix it, free_irq is moved to the place without holding the spinlock. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia