Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread Firo Yang
On Wed, May 17, 2017 at 06:08:11PM +0200, walter harms wrote: > > >Am 17.05.2017 15:42, schrieb Firo Yang: >> On Wed, May 17, 2017 at 02:59:39PM +0200, walter harms wrote: >>> >>> >>> Am 17.05.2017 14:35, schrieb Firo Yang: The divisor s->par.bitrate will always be 0 until initialized by

Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread walter harms
Am 17.05.2017 15:42, schrieb Firo Yang: > On Wed, May 17, 2017 at 02:59:39PM +0200, walter harms wrote: >> >> >> Am 17.05.2017 14:35, schrieb Firo Yang: >>> The divisor s->par.bitrate will always be 0 until initialized by >>> ndo_open() and hdlcdrv_open(). >>> >>> In order to fix this divide zero

Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread Firo Yang
On Wed, May 17, 2017 at 02:59:39PM +0200, walter harms wrote: > > >Am 17.05.2017 14:35, schrieb Firo Yang: >> The divisor s->par.bitrate will always be 0 until initialized by >> ndo_open() and hdlcdrv_open(). >> >> In order to fix this divide zero error, check whether the netdevice >> was opened b

Re: [PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread walter harms
Am 17.05.2017 14:35, schrieb Firo Yang: > The divisor s->par.bitrate will always be 0 until initialized by > ndo_open() and hdlcdrv_open(). > > In order to fix this divide zero error, check whether the netdevice > was opened by ndo_open() before performing divide. > > Reported-by: Dmitry Vyukov

[PATCH] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-17 Thread Firo Yang
The divisor s->par.bitrate will always be 0 until initialized by ndo_open() and hdlcdrv_open(). In order to fix this divide zero error, check whether the netdevice was opened by ndo_open() before performing divide. Reported-by: Dmitry Vyukov Signed-off-by: Firo Yang --- drivers/net/hamradio/hd