Re: [PATCH] fsl/fman_port: remove redundant check on port->rev_info.major

2018-04-24 Thread David Miller
From: Colin King Date: Tue, 24 Apr 2018 12:39:45 +0100 > From: Colin Ian King > > The check port->rev_info.major >= 6 is being performed twice, thus > the inner second check is always true and is redundant, hence it > can be removed. Detected by cppcheck. > > drivers/net/ethernet/freescale/fma

[PATCH] fsl/fman_port: remove redundant check on port->rev_info.major

2018-04-24 Thread Colin King
From: Colin Ian King The check port->rev_info.major >= 6 is being performed twice, thus the inner second check is always true and is redundant, hence it can be removed. Detected by cppcheck. drivers/net/ethernet/freescale/fman/fman_port.c:1394]: (warning) Identical inner 'if' condition is always