Re: [PATCH] forcedeth: suggested cleanups

2006-04-11 Thread Ingo Oeser
Hi Manfred, Manfred Spraul wrote: > I think the patch should wait until 0.57 is merged: There are 4 patches > on their way to Jeff. > These patches contain several bugfixes, they should have the higher > priority. Fine with me. Will resubmit after next week. > Apart from that: looks good. Ma

Re: [PATCH] forcedeth: suggested cleanups

2006-04-10 Thread Manfred Spraul
Ingo Oeser wrote: Hi there, here are some suggested cleanups, which compiled without problems using allyesconfig on the latest net-2.6 git tree from David S. Miller. Please review and apply, if convienient. I think the patch should wait until 0.57 is merged: There are 4 patches on their w

[PATCH] forcedeth: suggested cleanups

2006-04-10 Thread Ingo Oeser
From: Ingo Oeser <[EMAIL PROTECTED]> general: - endian annotation of the ring descriptors nv_getlen(): - use htons() instead of __constant_htons() to improvde readability and let the compiler constant fold it. nv_rx_process(): - use a real for() loop in processi