Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-31 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 13:51:12 -0800 > Normally during a dump the key of the last dumped entry is used for > continuation, but since lock is dropped it might be lost. In that case > fallback to the old counter based N^2 behaviour. This means the dump w

Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Jarek Poplawski
On Fri, Jan 25, 2008 at 08:13:15AM -0800, Stephen Hemminger wrote: ... > 2. RCU is unnecessary here because of use of RTNL. I am going to defer >on this till after #1. That patch is much less important. Thanks! (I've started to suspect another advanced RCU trick already...) Jarek P. -- To un

Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Stephen Hemminger
On Fri, 25 Jan 2008 09:23:00 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 24-01-2008 22:51, Stephen Hemminger wrote: > > Normally during a dump the key of the last dumped entry is used for > > continuation, but since lock is dropped it might be lost. In that case > > fallback to the old c

Re: [PATCH] fib_trie: rescan if key is lost during dump

2008-01-25 Thread Jarek Poplawski
On 24-01-2008 22:51, Stephen Hemminger wrote: > Normally during a dump the key of the last dumped entry is used for > continuation, but since lock is dropped it might be lost. In that case > fallback to the old counter based N^2 behaviour. This means the dump will > end up > skipping some routes

[PATCH] fib_trie: rescan if key is lost during dump

2008-01-24 Thread Stephen Hemminger
Normally during a dump the key of the last dumped entry is used for continuation, but since lock is dropped it might be lost. In that case fallback to the old counter based N^2 behaviour. This means the dump will end up skipping some routes which matches what FIB_HASH does. Signed-off-by: Stephe