RE: [PATCH] fec: Do not access unexisting register in Coldfire

2016-03-31 Thread Fugang Duan
From: Fabio Estevam Sent: Thursday, March 31, 2016 11:05 PM > To: da...@davemloft.net > Cc: Fugang Duan ; troy.ki...@boundarydevices.com; > g...@uclinux.org; netdev@vger.kernel.org; Fabio Estevam > > Subject: [PATCH] fec: Do not access unexisting register in Coldfire > >

Re: [PATCH] fec: Do not access unexisting register in Coldfire

2016-03-31 Thread Greg Ungerer
Thanks for taking care of that Fabio. Regards Greg On 01/04/16 01:05, Fabio Estevam wrote: > From: Fabio Estevam > > Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error > messages") introduces a write to a register that does not exist in > Coldfire. > > Move the FEC_FTRL regis

Re: [PATCH] fec: Do not access unexisting register in Coldfire

2016-03-31 Thread David Miller
From: Fabio Estevam Date: Thu, 31 Mar 2016 12:05:17 -0300 > From: Fabio Estevam > > Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error > messages") introduces a write to a register that does not exist in > Coldfire. > > Move the FEC_FTRL register access inside the FEC_QUIRK_HA

[PATCH] fec: Do not access unexisting register in Coldfire

2016-03-31 Thread Fabio Estevam
From: Fabio Estevam Commit 55cd48c821de ("net: fec: stop the "rcv is not +last, " error messages") introduces a write to a register that does not exist in Coldfire. Move the FEC_FTRL register access inside the FEC_QUIRK_HAS_RACC 'if' block, so that we guarantee it will not be used on Coldfire CP