Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-04-26 Thread Vlad Zakharov
Hi David, all, On Wed, 2017-03-29 at 14:30 -0700, David Miller wrote: > From: Vlad Zakharov > Date: Wed, 29 Mar 2017 13:41:46 +0300 > > > > > After a new NAPI_STATE_MISSED state was added to NAPI we can get into > > this state and in such case we have to reschedule NAPI as some work is > > stil

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-30 Thread Eric Dumazet
On Thu, Mar 30, 2017 at 2:16 AM, Vlad Zakharov wrote: > I am not sure what is happening with other drivers, but in case of ezchip > nps_enet driver after the following commit: > 39e6c8208d7b6fb9d2047850fb3327db567b564b > > if we got into NAPI_STATE_MISSED state the following happened: > in nps_e

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-30 Thread Vlad Zakharov
Hi Eric, On Wed, 2017-03-29 at 14:41 -0700, Eric Dumazet wrote: > On Wed, Mar 29, 2017 at 2:30 PM, David Miller wrote: > Signed-off-by: Vlad Zakharov > > > > > > Applied. > > > > Eric, if this is really required now, we have 148 broken drivers still. > > Piece of cake :/ > > If we get more

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-29 Thread Eric Dumazet
On Wed, Mar 29, 2017 at 2:30 PM, David Miller wrote: Signed-off-by: Vlad Zakharov > > Applied. > > Eric, if this is really required now, we have 148 broken drivers still. Piece of cake :/ If we get more reports like that, we might implement a logic to prevent infinite loops. It is not clear to

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-29 Thread David Miller
From: Vlad Zakharov Date: Wed, 29 Mar 2017 13:41:46 +0300 > After a new NAPI_STATE_MISSED state was added to NAPI we can get into > this state and in such case we have to reschedule NAPI as some work is > still pending and we have to process it. napi_complete_done() function > returns false if we

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-29 Thread Eric Dumazet
On Wed, 2017-03-29 at 13:41 +0300, Vlad Zakharov wrote: > After a new NAPI_STATE_MISSED state was added to NAPI we can get into > this state and in such case we have to reschedule NAPI as some work is > still pending and we have to process it. napi_complete_done() function > returns false if we hav

[PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-29 Thread Vlad Zakharov
After a new NAPI_STATE_MISSED state was added to NAPI we can get into this state and in such case we have to reschedule NAPI as some work is still pending and we have to process it. napi_complete_done() function returns false if we have to reschedule something (e.g. in case we were in MISSED state)