Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex

2019-04-08 Thread David Miller
From: Michael Zhivich Date: Mon, 8 Apr 2019 15:00:46 -0400 > Use constants provided by ethtool.h for speed and duplex values > instead of raw integer constants to increase code readability. > > thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants, > also provided by ethtool.h. >

Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex

2019-04-08 Thread Andrew Lunn
On Mon, Apr 08, 2019 at 03:00:46PM -0400, Michael Zhivich wrote: > Use constants provided by ethtool.h for speed and duplex values > instead of raw integer constants to increase code readability. > > thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants, > also provided by ethtool.h.

[PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex

2019-04-08 Thread Michael Zhivich
Use constants provided by ethtool.h for speed and duplex values instead of raw integer constants to increase code readability. thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants, also provided by ethtool.h. Signed-off-by: Michael Zhivich --- drivers/net/ethernet/cavium/thunder/