Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 00:20:37 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > Add the missing 'select CRC32' entries in Kconfig for each of them. > > Signed-off-by: A

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Arnd Bergmann
On Fri, Dec 4, 2020 at 12:03 PM Simon Horman wrote: > > I'm slightly curious to know how you configured the kernel to build > the Netronome NFP driver but not CRC32 but nonetheless I have no > objection to this change. I ran into one link error on a randconfig build and then tried an 'allyesconfi

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Nicolas Ferre
On 04/12/2020 at 00:20, Arnd Bergmann wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe From: Arnd Bergmann A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise: arm-linux-gnuea

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Simon Horman
On Fri, Dec 04, 2020 at 12:20:37AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > > arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function > `et131

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Mark Einon
On Fri, 2020-12-04 at 00:20 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > > arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function > `et1310_setup_

RE: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Madalin Bucur (OSS)
gt; Cc: Arnd Bergmann ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; oss- > driv...@netronome.com > Subject: [PATCH] ethernet: select CONFIG_CRC32 as needed > > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to

[PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise: arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast': et131x.c:(.text+0x5918): undefined reference t