Re: [PATCH] ethernet: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-08-23 Thread Scott Branden
On 2019-08-23 7:08 a.m., Christophe JAILLET wrote: Hi, in this patch, there is one piece that looked better before. (see below) Removing the 'if (skb)' is fine, but concatening everything in one statement just to save 2 variables and a few LOC is of no use, IMHO, and the code is less readab

Re: [PATCH] ethernet: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-08-23 Thread Christophe JAILLET
Hi, in this patch, there is one piece that looked better before. (see below) Removing the 'if (skb)' is fine, but concatening everything in one statement just to save 2 variables and a few LOC is of no use, IMHO, and the code is less readable. just my 2c. CJ diff --git a/drivers/net/ethe