Re: [PATCH] e1000: disable polling before registering netdevice

2007-06-03 Thread Jeff Garzik
Auke Kok wrote: To assure the symmetry of poll enable/disable in up/down, we should initialize the netdevice to be poll_disabled at load time. Doing this after register_netdevice leaves us open to another race, so lets move all the netif_* calls above register_netdevice so the stack starts out ho

Re: [PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Doug Chapman
On Fri, 2007-06-01 at 10:22 -0700, Auke Kok wrote: > To assure the symmetry of poll enable/disable in up/down, we should > initialize the netdevice to be poll_disabled at load time. Doing > this after register_netdevice leaves us open to another race, so > lets move all the netif_* calls above regi

Re: [PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Herbert Xu
On Fri, Jun 01, 2007 at 10:22:39AM -0700, Auke Kok wrote: > To assure the symmetry of poll enable/disable in up/down, we should > initialize the netdevice to be poll_disabled at load time. Doing > this after register_netdevice leaves us open to another race, so > lets move all the netif_* calls abo

[PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Auke Kok
To assure the symmetry of poll enable/disable in up/down, we should initialize the netdevice to be poll_disabled at load time. Doing this after register_netdevice leaves us open to another race, so lets move all the netif_* calls above register_netdevice so the stack starts out how we expect it to