Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-17 Thread Jeff Garzik
Auke Kok wrote: pci_enable_msi failure is a normal event so we should not print any error. Going over the code I spotted a missing pci_disable_msi() leak when irq allocation fails. The whole code also needed a cleanup, so I combined the two different calls to pci_request_irq into a single call ma

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Jeff Garzik
Rick Jones wrote: Agreed. But is the PCI (?) subsystem doing something in that regard or is this a hole? Depends on your platform, your BIOS, your kernel command line, ... :) Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Rick Jones
Jeff Garzik wrote: Rick Jones wrote: But that is rather incidental isn't it? Would some sort of system health monitor be likely to be checking that for interrupt flavors? And Well, that's where the information is exported in a standard way. I hope you're not suggesting that a system hea

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 16 May 2007 11:41:15 -0700 > Some more of my paranoid questions :) > > So, if a driver tries to enable MSI and that is unsuccessful (I'll try to > avoid > using the possibly loaded term "fails") shouldn't that show-up _somewhere_? > Just how "nor

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Jeff Garzik
Rick Jones wrote: But that is rather incidental isn't it? Would some sort of system health monitor be likely to be checking that for interrupt flavors? And Well, that's where the information is exported in a standard way. I hope you're not suggesting that a system health monitor should be

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Rick Jones
H. Peter Anvin wrote: Rick Jones wrote: Some more of my paranoid questions :) So, if a driver tries to enable MSI and that is unsuccessful (I'll try to avoid using the possibly loaded term "fails") shouldn't that show-up _somewhere_? It already does -- in /proc/interrupts. But that is rat

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Jeff Garzik
Rick Jones wrote: So, if a driver tries to enable MSI and that is unsuccessful (I'll try to avoid using the possibly loaded term "fails") shouldn't that show-up _somewhere_? Just how "normal" is an attempt to enable MSI not succeding going to remain over time and aren't there times when it does

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread H. Peter Anvin
Rick Jones wrote: > Some more of my paranoid questions :) > > So, if a driver tries to enable MSI and that is unsuccessful (I'll try > to avoid using the possibly loaded term "fails") shouldn't that show-up > _somewhere_? It already does -- in /proc/interrupts. > Just how "normal" is an attempt

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Rick Jones
Some more of my paranoid questions :) So, if a driver tries to enable MSI and that is unsuccessful (I'll try to avoid using the possibly loaded term "fails") shouldn't that show-up _somewhere_? Just how "normal" is an attempt to enable MSI not succeding going to remain over time and aren't the

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
pci_enable_msi failure is a normal event so we should not print any error. Going over the code I spotted a missing pci_disable_msi() leak when irq allocation fails. The whole code also needed a cleanup, so I combined the two different calls to pci_request_irq into a single call making this look a l

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Jeff Garzik
Auke Kok wrote: pci_enable_msi failure is a normal event so we should not print any error. Going over the code I spotted a missing pci_disable_msi() leak when irq allocation fails. The whole code also needed a cleanup, so I combined the two different calls to pci_request_irq into a single call ma

Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: pci_enable_msi failure is a normal event so we should not print any error. Going over the code I spotted a missing pci_disable_msi() leak when irq allocation fails. The whole code also needed a cleanup, so I combined the two different calls to pci_request_irq i

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
pci_enable_msi failure is a normal event so we should not print any error. Going over the code I spotted a missing pci_disable_msi() leak when irq allocation fails. The whole code also needed a cleanup, so I combined the two different calls to pci_request_irq into a single call making this look a l