Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-17 Thread Jeff Garzik
Auke Kok wrote: To help supporting users with a bad eeprom checksum, dump the eeprom info when such a situation is encountered by a user. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 85 +++- 1 files changed, 74 insertio

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-17 Thread Joe Perches
On Mon, 2007-12-17 at 13:50 -0800, Auke Kok wrote: > diff --git a/drivers/net/e1000/e1000_main.c > b/drivers/net/e1000/e1000_main.c > index efd8c2d..aac55be 100644 > --- a/drivers/net/e1000/e1000_main.c > +++ b/drivers/net/e1000/e1000_main.c > @@ -979,23 +1036,29 @@ e1000_probe(struct pci_dev *pdev

[PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-17 Thread Auke Kok
To help supporting users with a bad eeprom checksum, dump the eeprom info when such a situation is encountered by a user. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 85 +++- 1 files changed, 74 insertions(+), 11 deletion

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-15 Thread Kok, Auke
Joe Perches wrote: > On Fri, 2007-12-14 at 15:35 -0800, Auke Kok wrote: >> +printk(KERN_ERR "/*/\n"); >> +printk(KERN_ERR "Current EEPROM: 0x%04x\nCalculated: 0x%04x\n", >> + csum_old, csum_new); > > Multiline printks need a KERN_ after every newline. Pe

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Joe Perches
On Fri, 2007-12-14 at 15:35 -0800, Auke Kok wrote: > + printk(KERN_ERR "/*/\n"); > + printk(KERN_ERR "Current EEPROM: 0x%04x\nCalculated: 0x%04x\n", > +csum_old, csum_new); Multiline printks need a KERN_ after every newline. Perhaps: printk(KE

Re: [PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Randy Dunlap
On Fri, 14 Dec 2007 15:35:30 -0800 Auke Kok wrote: > To help supporting users with a bad eeprom checksum, dump the > eeprom info when such a situation is encountered by a user. > > Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > --- > > drivers/net/e1000/e1000_main.c | 90 > +++

[PATCH] e1000: Dump the eeprom when a user encounters a bad checksum

2007-12-14 Thread Auke Kok
To help supporting users with a bad eeprom checksum, dump the eeprom info when such a situation is encountered by a user. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 90 +++- 1 files changed, 79 insertions(+), 11 deletion