Re: [PATCH] dscc4: Undefined signed int shift

2016-02-13 Thread David Miller
From: Michael McConville Date: Fri, 5 Feb 2016 20:46:25 -0500 > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time. > > Signed-

Re: [PATCH] dscc4: Undefined signed int shift

2016-02-06 Thread Francois Romieu
Michael McConville : > My analysis in the below mail applies, although the second part is > unnecessary because i isn't used in arithmetic operations here: > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > Thanks for your time. Acked-by: Francois Romieu For all practical matters

[PATCH] dscc4: Undefined signed int shift

2016-02-05 Thread Michael McConville
My analysis in the below mail applies, although the second part is unnecessary because i isn't used in arithmetic operations here: https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 Thanks for your time. Signed-off-by: Michael McConville --- drivers/net/wan/dscc4.c | 2 +- 1 file changed,