Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-03 Thread Wolfgang Reiter
Yes, genlmsg_end changes nlmsg_len field dependent on skb->tail. After allocation in reset_per_cpu_data skb->tail is modified in trace_drop_common via __nla_reserve_nohdr. Best place for setting nlmsg_len to its final value is after being swapped out in reset_per_cpu_data. Neil Horman writes:

Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-03 Thread David Miller
From: Neil Horman Date: Tue, 3 Jan 2017 11:04:43 -0500 > On Tue, Jan 03, 2017 at 09:54:19AM -0500, David Miller wrote: >> From: Reiter Wolfgang >> Date: Tue, 3 Jan 2017 01:39:10 +0100 >> >> > Final nlmsg_len field update must reflect inserted net_dm_drop_point >> > data. >> > >> > This patch

Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-03 Thread Neil Horman
On Tue, Jan 03, 2017 at 09:54:19AM -0500, David Miller wrote: > From: Reiter Wolfgang > Date: Tue, 3 Jan 2017 01:39:10 +0100 > > > Final nlmsg_len field update must reflect inserted net_dm_drop_point > > data. > > > > This patch depends on previous patch: > > "drop_monitor: add missing call to

Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-03 Thread David Miller
From: Reiter Wolfgang Date: Tue, 3 Jan 2017 01:39:10 +0100 > Final nlmsg_len field update must reflect inserted net_dm_drop_point > data. > > This patch depends on previous patch: > "drop_monitor: add missing call to genlmsg_end" > > Signed-off-by: Reiter Wolfgang I don't understand why the

Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-03 Thread Neil Horman
On Tue, Jan 03, 2017 at 01:39:10AM +0100, Reiter Wolfgang wrote: > Final nlmsg_len field update must reflect inserted net_dm_drop_point > data. > > This patch depends on previous patch: > "drop_monitor: add missing call to genlmsg_end" > > Signed-off-by: Reiter Wolfgang > --- > net/core/drop_mo

[PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-02 Thread Reiter Wolfgang
Final nlmsg_len field update must reflect inserted net_dm_drop_point data. This patch depends on previous patch: "drop_monitor: add missing call to genlmsg_end" Signed-off-by: Reiter Wolfgang --- net/core/drop_monitor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-02 Thread David Miller
From: Reiter Wolfgang Date: Tue, 3 Jan 2017 00:34:10 +0100 > Final nlmsg_len field update must reflect inserted net_dm_drop_point > data. > > This patch depends on previous patch: > "drop_monitor: add missing call to genlmsg_end" > > Signed-off-by: Reiter Wolfgang Several coding style errors

[PATCH] drop_monitor: consider inserted data in genlmsg_end

2017-01-02 Thread Reiter Wolfgang
Final nlmsg_len field update must reflect inserted net_dm_drop_point data. This patch depends on previous patch: "drop_monitor: add missing call to genlmsg_end" Signed-off-by: Reiter Wolfgang --- net/core/drop_monitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/n