Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes, take two

2005-08-10 Thread David S. Miller
From: Peter Hagervall <[EMAIL PROTECTED]> Date: Tue, 9 Aug 2005 09:49:10 +0200 > This patch contains the following possible cleanups/fixes: Applied to net-2.6.14, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

[PATCH] drivers/net/bnx2.c Possible sparse fixes, take two

2005-08-09 Thread Peter Hagervall
This patch contains the following possible cleanups/fixes: - use C99 struct initializers - make a few arrays and structs static - remove a few uses of literal 0 as NULL pointer - use convenience function instead of cast+dereference in bnx2_ioctl() - remove superfluous casts to u8 * in calls to rea

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Mon, 08 Aug 2005 17:35:05 -0700 > I ACK all the other changes. Ok, please make the changes Michael and myself have noted and send the updated patch so I can add it to the net tree. Thanks. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread Michael Chan
On Tue, 2005-08-09 at 01:09 +0200, Peter Hagervall wrote: > This patch contains the following possible cleanups/fixes: > > - use C99 struct initializers > - make a few arrays and structs static > - remove a few uses of literal 0 as NULL pointer > - add __force attribute in cast to silence sparse >

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread David S. Miller
From: Peter Hagervall <[EMAIL PROTECTED]> Date: Tue, 9 Aug 2005 01:09:40 +0200 > - { 0 }, > + { "" }, It wanst NULL, not an empty string. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

[PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread Peter Hagervall
This patch contains the following possible cleanups/fixes: - use C99 struct initializers - make a few arrays and structs static - remove a few uses of literal 0 as NULL pointer - add __force attribute in cast to silence sparse - remove casts to u8 * in calls to readl/writel I'm not sure about rem