On Tue, 2020-05-19 at 17:06 +0100, David Howells wrote:
> Okay, how about this incremental change, then? If fixes the typo, only prints
> the "READ CONFIG" line in verbose mode, filters escape chars in the config
> file and reduces the expiration time to 5s.
>
> David
> ---
> diff --git a/key.dns
On Tue, May 19, 2020 at 17:06:49 +0100, David Howells wrote:
> Okay, how about this incremental change, then? If fixes the typo, only prints
> the "READ CONFIG" line in verbose mode, filters escape chars in the config
> file and reduces the expiration time to 5s.
Thanks! Looks good to me.
Review
Okay, how about this incremental change, then? If fixes the typo, only prints
the "READ CONFIG" line in verbose mode, filters escape chars in the config
file and reduces the expiration time to 5s.
David
---
diff --git a/key.dns_resolver.c b/key.dns_resolver.c
index c241eda3..7a7ec424 100644
--- a
* David Howells:
> Fix this to apply a default TTL of 10mins in the event that we haven't got
> one. This can be configured in /etc/keyutils/key.dns_resolver.conf by
> adding the line:
>
> default_ttl:
>
> to the file.
If the name resolution is not needed continuously, but only for the
co
On Tue, May 19, 2020 at 14:39:40 +0100, David Howells wrote:
> Ben Boeckel wrote:
> > Is there precedent for this config file format?
>
> Okay, I can change it to:
>
> default_ttl =
>
> and strip spaces all over the place.
Thanks. This is at least a subset of other formats with specs th
Ben Boeckel wrote:
> Is there precedent for this config file format?
Okay, I can change it to:
default_ttl =
and strip spaces all over the place.
> But no trailing whitespace is allowed?
Yes... See a few lines above:
while (p > buf && isspace(p[-1]))
On Mon, May 18, 2020 at 15:22:45 +0100, David Howells wrote:
> Address records obtained from getaddrinfo() don't come with any TTL
> information, even if they're obtained from the DNS, with the result that
> key.dns_resolver upcall program doesn't set an expiry time on dns_resolver
> records unless
Address records obtained from getaddrinfo() don't come with any TTL
information, even if they're obtained from the DNS, with the result that
key.dns_resolver upcall program doesn't set an expiry time on dns_resolver
records unless they include a component obtained directly from the DNS,
such as an
