Re: [PATCH] ctnetlink: fix conntrack expect refcount leak

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:28:20 +0200 > [NETFILTER] fix conntrack refcount leak in unlink_expect() Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH] ctnetlink: fix typo in ctnl_exp_cb array

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:21:42 +0200 > [NETFILTER] Fix typo in ctnl_exp_cb array (no bug, just memory waste) Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: [PATCH] ctnetlink: fix list traversal order

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:26:50 +0200 > [NETFILTER] fix list traversal order in ctnetlink Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] ctnetlink: make sure event order is correct

2005-08-05 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 5 Aug 2005 18:27:38 +0200 > [NETFILTER] ctnetlink: make sure event order is correct Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

[PATCH] ctnetlink: make sure event order is correct

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] ctnetlink: make sure event order is correct The following sequence is displayed during events dumping of an ICMP connection: [NEW] [DESTROY] [UPDATE] This happens because the event IPCT_DESTROY is delivered in death_by_timeout(), that is called from the icmp pr

[PATCH] ctnetlink: fix typo in ctnl_exp_cb array

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] Fix typo in ctnl_exp_cb array (no bug, just memory waste) This fixes the size of the ctnl_exp_cb array that is IPCTNL_MSG_EXP_MAX instead of IPCTNL_MSG_MAX. Simple typo. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PR

[PATCH] ctnetlink: fix conntrack expect refcount leak

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] fix conntrack refcount leak in unlink_expect() In unlink_expect(), the expectation is removed from the list so the refcount must be dropped as well. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit

[PATCH] ctnetlink: fix list traversal order

2005-08-05 Thread Harald Welte
Hi Dave, please apply. [NETFILTER] fix list traversal order in ctnetlink Currently conntracks are inserted after the head. That means that conntracks are sorted from the biggest to the smallest id. This happens because we use list_prepend (list_add) instead list_add_tail. This can result in probl

Re: [PATCH] ctnetlink

2005-07-22 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Fri, 22 Jul 2005 09:11:30 -0400 > This is a patch for your net-2.6.14 tree (incremental to the > expect-double-free fix). It adds the ctnetlink code, and all the > required core conntrack/nat changes that it needs. Applied and pushed to net-2.6.14 - T