Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread David Miller
From: Evgeniy Polyakov Date: Mon, 30 Apr 2018 18:01:30 +0300 > Stefan, hi > > Sorry for delay. > > 26.04.2018, 15:04, "Stefan Strogin" : >> Hi David, Evgeniy, >> >> Sorry to bother you, but could you please comment about the UAPI change and >> the patch? > > With 4-bytes pid_t everything look

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread Evgeniy Polyakov
Stefan, hi Sorry for delay. 26.04.2018, 15:04, "Stefan Strogin" : > Hi David, Evgeniy, > > Sorry to bother you, but could you please comment about the UAPI change and > the patch? With 4-bytes pid_t everything looks fine, and I do not know arch where pid is larger currently, so it looks safe.

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-26 Thread Stefan Strogin
il.com; matt.hels...@gmail.com; mini...@googlemail.com > Ämne: Re: [PATCH] connector: add parent pid and tgid to coredump and exit > events > > Hi David, > > I don't see how it breaks UAPI. The point is that structures > coredump_proc_event and exit_proc_event are members

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-02 Thread Stefan Strogin
Hi David, I don't see how it breaks UAPI. The point is that structures coredump_proc_event and exit_proc_event are members of *union* event_data, thus position of the existing data in the structure is unchanged. Furthermore, this change won't increase size of struct proc_event, because comm_proc_e

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-03-30 Thread David Miller
From: Stefan Strogin Date: Thu, 29 Mar 2018 17:12:47 +0300 > diff --git a/include/uapi/linux/cn_proc.h b/include/uapi/linux/cn_proc.h > index 68ff25414700..db210625cee8 100644 > --- a/include/uapi/linux/cn_proc.h > +++ b/include/uapi/linux/cn_proc.h > @@ -116,12 +116,16 @@ struct proc_event { >

[PATCH] connector: add parent pid and tgid to coredump and exit events

2018-03-29 Thread Stefan Strogin
The intention is to get notified of process failures as soon as possible, before a possible core dumping (which could be very long) (e.g. in some process-manager). Coredump and exit process events are perfect for such use cases (see 2b5faa4c553f "connector: Added coredumping event to the process co