Re: [PATCH] cnic: remove redundant assignment to variable ret

2020-05-09 Thread Dan Carpenter
On Fri, May 08, 2020 at 11:40:26PM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King We used to retur

Re: [PATCH] cnic: remove redundant assignment to variable ret

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 23:40:26 +0100 Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thank you!

Re: [PATCH] cnic: remove redundant assignment to variable ret

2020-05-08 Thread Michael Chan
On Fri, May 8, 2020 at 3:40 PM Colin King wrote: > > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Michael Chan

[PATCH] cnic: remove redundant assignment to variable ret

2020-05-08 Thread Colin King
From: Colin Ian King The variable ret is being assigned with a value that is never read, the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/ethernet/broadcom/cnic.c | 1 - 1 file changed, 1 deletion(-) diff --git