Re: [PATCH] cleanup ieee80211_crypto.c

2005-11-08 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] cleanup ieee80211_crypto.c

2005-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2005 at 06:46:12AM +0100, Christoph Hellwig wrote: > On Fri, Sep 09, 2005 at 04:36:26PM +0200, Christoph Hellwig wrote: > > On Thu, Sep 08, 2005 at 12:59:29AM -0400, Jeff Garzik wrote: > > > Would you be kind enough to resend -again-, rediff'd against latest > > > upstream git tree

Re: [PATCH] cleanup ieee80211_crypto.c

2005-11-06 Thread Christoph Hellwig
On Fri, Sep 09, 2005 at 04:36:26PM +0200, Christoph Hellwig wrote: > On Thu, Sep 08, 2005 at 12:59:29AM -0400, Jeff Garzik wrote: > > Would you be kind enough to resend -again-, rediff'd against latest > > upstream git tree? > > Here we go.. and here it is again, rediffed against the nth time:

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-09 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 12:59:29AM -0400, Jeff Garzik wrote: > Would you be kind enough to resend -again-, rediff'd against latest > upstream git tree? Here we go.. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/include/net/ieee80211_crypt.h ==

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-08 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 12:59:29AM -0400, Jeff Garzik wrote: > >Index: linux-2.6/net/ieee80211/ieee80211_crypt.c > >=== > >--- linux-2.6.orig/net/ieee80211/ieee80211_crypt.c 2005-09-05 > >14:38:19.0 +0200 > >+++ linux-2.6/ne

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-07 Thread Jeff Garzik
Christoph Hellwig wrote: On Mon, Sep 05, 2005 at 12:48:45PM -0400, Jeff Garzik wrote: I understand removing the NULL pointers, but .name is actually a string "NULL".. Leaving it to be NULL is not a very good idea. This "NULL" algorithm was designed for cases where there is default algorithm for

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-06 Thread Christoph Hellwig
On Mon, Sep 05, 2005 at 12:48:45PM -0400, Jeff Garzik wrote: > >>I understand removing the NULL pointers, but .name is actually a string > >>"NULL".. Leaving it to be NULL is not a very good idea. This "NULL" > >>algorithm was designed for cases where there is default algorithm for > >>encryption a

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-05 Thread Jeff Garzik
Christoph Hellwig wrote: On Mon, Sep 05, 2005 at 11:15:20AM +0300, Jouni Malinen wrote: I understand removing the NULL pointers, but .name is actually a string "NULL".. Leaving it to be NULL is not a very good idea. This "NULL" algorithm was designed for cases where there is default algorithm f

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-05 Thread Christoph Hellwig
On Mon, Sep 05, 2005 at 11:15:20AM +0300, Jouni Malinen wrote: > I understand removing the NULL pointers, but .name is actually a string > "NULL".. Leaving it to be NULL is not a very good idea. This "NULL" > algorithm was designed for cases where there is default algorithm for > encryption and enc

[PATCH] cleanup ieee80211_crypto.c

2005-09-04 Thread Christoph Hellwig
- use proper list handling - avoid hcrypt structure, just use a proper static list_head and spinlock - use proper instead of the variants Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/net/ieee80211/ieee80211_crypt.c