Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 04 Mar 2021 16:29:51 -0500 you wrote: > The current CIPSO and CALIPSO refcounting scheme for the DOI > definitions is a bit flawed in that we: > > 1. Don't correctly match gets/puts in netlbl_cipsov4_list(). > 2. Decrem

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread David Miller
From: Paul Moore Date: Thu, 4 Mar 2021 18:13:21 -0500 > On Thu, Mar 4, 2021 at 5:33 PM David Miller wrote: >> From: Paul Moore >> Date: Thu, 04 Mar 2021 16:29:51 -0500 >> >> > +static void calipso_doi_putdef(struct calipso_doi *doi_def); >> > + >> >> This is a global symbol, so why the static d

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread Paul Moore
On Thu, Mar 4, 2021 at 5:33 PM David Miller wrote: > From: Paul Moore > Date: Thu, 04 Mar 2021 16:29:51 -0500 > > > +static void calipso_doi_putdef(struct calipso_doi *doi_def); > > + > > This is a global symbol, so why the static decl here? To resolve this: CC net/ipv6/calipso.o net/ipv

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread David Miller
From: Paul Moore Date: Thu, 04 Mar 2021 16:29:51 -0500 > +static void calipso_doi_putdef(struct calipso_doi *doi_def); > + This is a global symbol, so why the static decl here? Thanks.

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread Paul Moore
On Thu, Mar 4, 2021 at 4:29 PM Paul Moore wrote: > > The current CIPSO and CALIPSO refcounting scheme for the DOI > definitions is a bit flawed in that we: > > 1. Don't correctly match gets/puts in netlbl_cipsov4_list(). > 2. Decrement the refcount on each attempt to remove the DOI from the >D

[PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread Paul Moore
The current CIPSO and CALIPSO refcounting scheme for the DOI definitions is a bit flawed in that we: 1. Don't correctly match gets/puts in netlbl_cipsov4_list(). 2. Decrement the refcount on each attempt to remove the DOI from the DOI list, only removing it from the list once the refcount drops