Re: [PATCH] can: mark expected switch fall-throughs

On 2/26/19 2:02 AM, Marc Kleine-Budde wrote: > On 1/29/19 7:06 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/net/can/peak_canfd/peak_pc

Re: [PATCH] can: mark expected switch fall-throughs

On 1/29/19 7:06 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/can/peak_canfd/peak_pciefd_main.c:668:3: warning: this statement > may fall

Re: [PATCH] can: mark expected switch fall-throughs

Hi, Friendly ping: Dave, I wonder if you can take this. Thanks -- Gustavo On 2/14/19 3:37 PM, Gustavo A. R. Silva wrote: > > > On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote: >> On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, ma

Re: [PATCH] can: mark expected switch fall-throughs

On 14/02/2019 17:14:05-0600, Gustavo A. R. Silva wrote: > >>> Also, the gcc documentation says that -Wimplicit-fallthrough=3 > >>> recognizes /* fallthrough */ as a proper fall through comment (and I > >>> tested with gcc 8.2). > >>> > >> > >> Yeah. But that's not the relevant change in this case.

Re: [PATCH] can: mark expected switch fall-throughs

On 2/14/19 5:07 PM, Alexandre Belloni wrote: > On 14/02/2019 17:04:03-0600, Gustavo A. R. Silva wrote: >> >> >> On 2/14/19 4:17 PM, Alexandre Belloni wrote: >>> Hi, >>> >>> On 14/02/2019 15:37:26-0600, Gustavo A. R. Silva wrote: On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrot

Re: [PATCH] can: mark expected switch fall-throughs

On 14/02/2019 17:04:03-0600, Gustavo A. R. Silva wrote: > > > On 2/14/19 4:17 PM, Alexandre Belloni wrote: > > Hi, > > > > On 14/02/2019 15:37:26-0600, Gustavo A. R. Silva wrote: > >> > >> > >> On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote: > >>> On 29/01/2019 at 19:06, Gustavo A. R. Sil

Re: [PATCH] can: mark expected switch fall-throughs

On 2/14/19 4:17 PM, Alexandre Belloni wrote: > Hi, > > On 14/02/2019 15:37:26-0600, Gustavo A. R. Silva wrote: >> >> >> On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote: >>> On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark swit

Re: [PATCH] can: mark expected switch fall-throughs

Hi, On 14/02/2019 15:37:26-0600, Gustavo A. R. Silva wrote: > > > On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote: > > On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases > >> where we are expecting to fall through. >

Re: [PATCH] can: mark expected switch fall-throughs

On 1/30/19 2:11 AM, nicolas.fe...@microchip.com wrote: > On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/net/can/peak

Re: [PATCH] can: mark expected switch fall-throughs

On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/can/peak_canfd/peak_pciefd_main.c:668:3: warning: this statement > may

[PATCH] can: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/net/can/peak_canfd/peak_pciefd_main.c:668:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/can/spi/mcp251