Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-27 Thread Marc Kleine-Budde
On 10/27/20 12:27 PM, Yegor Yefremov wrote: >>> Can you add a row description that indicated that these numbers are. They >>> are >>> probably bit positions within the CAN-ID? >> >> This is true for up to 99.9%, depending on who you ask. >> this maps indeed to the bit positions in the CAN-ID, as i

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-27 Thread Yegor Yefremov
On Thu, Oct 22, 2020 at 2:25 PM Kurt Van Dijck wrote: > > On Thu, 22 Oct 2020 12:33:45 +0200, Marc Kleine-Budde wrote: > > On 10/22/20 12:29 PM, yegorsli...@googlemail.com wrote: > > > From: Yegor Yefremov > > > > > > Use table markup to show the PGN structure. > > > > > > Signed-off-by: Yegor Ye

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-22 Thread Kurt Van Dijck
On Thu, 22 Oct 2020 12:33:45 +0200, Marc Kleine-Budde wrote: > On 10/22/20 12:29 PM, yegorsli...@googlemail.com wrote: > > From: Yegor Yefremov > > > > Use table markup to show the PGN structure. > > > > Signed-off-by: Yegor Yefremov > > --- > > Documentation/networking/j1939.rst | 12

Re: [PATCH] can: j1939: convert PGN structure to a table

2020-10-22 Thread Marc Kleine-Budde
On 10/22/20 12:29 PM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Use table markup to show the PGN structure. > > Signed-off-by: Yegor Yefremov > --- > Documentation/networking/j1939.rst | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Doc

[PATCH] can: j1939: convert PGN structure to a table

2020-10-22 Thread yegorslists
From: Yegor Yefremov Use table markup to show the PGN structure. Signed-off-by: Yegor Yefremov --- Documentation/networking/j1939.rst | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst index