Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-15 Thread Kalle Valo
Arend van Spriel writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafał Miłecki writes: >> > + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; > +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifndef? >>> >>> I followed what is used in the include/linux/eth

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:08, Kalle Valo wrote: Arend van Spriel writes: On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's firmwares can send 802.11f ADD

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 5:10 PM, Kalle Valo wrote: Rafał Miłecki writes: + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifndef? I followed what is used in the include/linux/etherdevice.h. Is that a good exceuse? Could it be the

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 4:57 PM, Rafał Miłecki wrote: On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 15:24, Kalle Valo wrote: Rafał Miłecki writes: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standa

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. Th

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Kalle Valo
Rafał Miłecki writes: >>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; >>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >> >> #ifndef? > > I followed what is used in the include/linux/etherdevice.h. Is that a > good exceuse? Could it be there any some good reason for #if

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Stephen Hemminger
On Wed, 14 Mar 2018 17:08:48 +0200 Kalle Valo wrote: > Arend van Spriel writes: > > > On 3/14/2018 3:24 PM, Kalle Valo wrote: > >>> +config BRCMFMAC_IAPP > >>> >+bool "Partial support for obsoleted Inter-Access Point Protocol" > >>> >+depends on BRCMFMAC > >>> >+---h

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Kalle Valo
Arend van Spriel writes: > On 3/14/2018 3:24 PM, Kalle Valo wrote: >>> +config BRCMFMAC_IAPP >>> >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >>> >+ depends on BRCMFMAC >>> >+ ---help--- >>> >+Most of Broadcom's firmwares can send 802.11f ADD frame every >>> >+ti

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Stephen Hemminger
On Wed, 14 Mar 2018 12:01:19 +0100 Rafał Miłecki wrote: > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > index 19048526b4af..db6987015fb1 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > +

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's firmwares can send 802.11f ADD frame every >+ time new STA connects to the AP interface. Some

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Kalle Valo
Rafał Miłecki writes: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. This is an obsoleted standard > and its implementation is som

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Arend van Spriel
On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standard and its implementa

[PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

2018-03-14 Thread Rafał Miłecki
From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standard and its implementation is something that: 1) Most people don't n