Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock

2021-02-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 9 Feb 2021 12:27:01 +0100 you wrote: > For double-checked locking in bpf_common_lru_push_free(), node->type is > read outside the critical section and then re-checked under the lock. > However, concurrent writes to no

Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock

2021-02-10 Thread Andrii Nakryiko
On Tue, Feb 9, 2021 at 10:00 PM Martin KaFai Lau wrote: > > On Tue, Feb 09, 2021 at 12:27:01PM +0100, Marco Elver wrote: > > For double-checked locking in bpf_common_lru_push_free(), node->type is > > read outside the critical section and then re-checked under the lock. > > However, concurrent wri

Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock

2021-02-09 Thread Martin KaFai Lau
On Tue, Feb 09, 2021 at 12:27:01PM +0100, Marco Elver wrote: > For double-checked locking in bpf_common_lru_push_free(), node->type is > read outside the critical section and then re-checked under the lock. > However, concurrent writes to node->type result in data races. > > For example, the follo