RE: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread David Laight
From: Ard Biesheuvel > Sent: 27 October 2020 20:57 > > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > function scope __attribute__((optimize("-fno-gcse"))), to disable a > GCC specific optimization that was ca

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Geert Uytterhoeven
Hi Ard, On Tue, Oct 27, 2020 at 9:57 PM Ard Biesheuvel wrote: > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > function scope __attribute__((optimize("-fno-gcse"))), to disable a > GCC specific optimization t

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Ard Biesheuvel
On Wed, 28 Oct 2020 at 00:04, Daniel Borkmann wrote: > > On 10/27/20 9:57 PM, Ard Biesheuvel wrote: > > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > > function scope __attribute__((optimize("-fno-gcse"))),

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Ard Biesheuvel
On Wed, 28 Oct 2020 at 07:51, Ard Biesheuvel wrote: > > On Wed, 28 Oct 2020 at 00:04, Daniel Borkmann wrote: > > > > On 10/27/20 9:57 PM, Ard Biesheuvel wrote: > > > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > > > ___bpf_prog_run()") introduced a __no_fgcse macro that expand

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-27 Thread Daniel Borkmann
On 10/27/20 9:57 PM, Ard Biesheuvel wrote: Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a function scope __attribute__((optimize("-fno-gcse"))), to disable a GCC specific optimization that was causing trouble on

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-27 Thread Ard Biesheuvel
On Tue, 27 Oct 2020 at 23:03, Nick Desaulniers wrote: > > On Tue, Oct 27, 2020 at 2:50 PM Ard Biesheuvel wrote: > > > > On Tue, 27 Oct 2020 at 22:20, Nick Desaulniers > > wrote: > > > > > > On Tue, Oct 27, 2020 at 1:57 PM Ard Biesheuvel wrote: > > > > > > > > diff --git a/include/linux/compile

Re: [PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-27 Thread Ard Biesheuvel
On Tue, 27 Oct 2020 at 22:20, Nick Desaulniers wrote: > > On Tue, Oct 27, 2020 at 1:57 PM Ard Biesheuvel wrote: > > > > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > > function scope __attribute__((optimiz

[PATCH] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-27 Thread Ard Biesheuvel
Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a function scope __attribute__((optimize("-fno-gcse"))), to disable a GCC specific optimization that was causing trouble on x86 builds, and was not expected to have any