Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread David Miller
From: Yang Shi Date: Fri, 30 Oct 2015 15:16:26 -0700 > When running bpf samples on rt kernel, it reports the below warning: ... > Convert hashtab lock to raw lock to avoid such warning. > > Signed-off-by: Yang Shi Applied to net-next, thanks. -- To unsubscribe from this list: send the line "u

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Shi, Yang
On 11/2/2015 9:24 AM, Steven Rostedt wrote: On Mon, 02 Nov 2015 09:12:29 -0800 "Shi, Yang" wrote: Yes, it is common practice for converting sleepable spin lock to raw spin lock in -rt to avoid scheduling in atomic context bug. Note, in a lot of cases we don't just convert spin_locks to raw b

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Daniel Borkmann
On 11/02/2015 06:12 PM, Shi, Yang wrote: ... If you think such info is necessary, I definitely could add it into the commit log in v2. As this is going to be documented anyway (thanks! ;)), and the discussion to this patch can be found in the archives for those wondering, I'm good: Acked-by:

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Steven Rostedt
On Mon, 02 Nov 2015 09:12:29 -0800 "Shi, Yang" wrote: > Yes, it is common practice for converting sleepable spin lock to raw > spin lock in -rt to avoid scheduling in atomic context bug. Note, in a lot of cases we don't just convert spin_locks to raw because of atomic context. There's times we

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Shi, Yang
On 10/31/2015 11:37 AM, Daniel Borkmann wrote: On 10/31/2015 02:47 PM, Steven Rostedt wrote: On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: When running bpf samples on rt kernel, it reports the below warning: BUG: sleepi

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Shi, Yang
On 11/2/2015 12:59 AM, Thomas Gleixner wrote: On Sun, 1 Nov 2015, Alexei Starovoitov wrote: On Sat, Oct 31, 2015 at 09:47:36AM -0400, Steven Rostedt wrote: On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: When running bpf

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Thomas Gleixner
On Sun, 1 Nov 2015, Alexei Starovoitov wrote: > On Sat, Oct 31, 2015 at 09:47:36AM -0400, Steven Rostedt wrote: > > On Fri, 30 Oct 2015 17:03:58 -0700 > > Alexei Starovoitov wrote: > > > > > On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: > > > > When running bpf samples on rt kernel, i

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-01 Thread Alexei Starovoitov
On Sat, Oct 31, 2015 at 09:47:36AM -0400, Steven Rostedt wrote: > On Fri, 30 Oct 2015 17:03:58 -0700 > Alexei Starovoitov wrote: > > > On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: > > > When running bpf samples on rt kernel, it reports the below warning: > > > > > > BUG: sleeping fu

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-10-31 Thread Daniel Borkmann
On 10/31/2015 02:47 PM, Steven Rostedt wrote: On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: When running bpf samples on rt kernel, it reports the below warning: BUG: sleeping function called from invalid context at kern

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-10-31 Thread Steven Rostedt
On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: > On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: > > When running bpf samples on rt kernel, it reports the below warning: > > > > BUG: sleeping function called from invalid context at > > kernel/locking/rtmutex.c:917 > > in

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-10-30 Thread Alexei Starovoitov
On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: > When running bpf samples on rt kernel, it reports the below warning: > > BUG: sleeping function called from invalid context at > kernel/locking/rtmutex.c:917 > in_atomic(): 1, irqs_disabled(): 128, pid: 477, name: ping > Preemption disab

[PATCH] bpf: convert hashtab lock to raw lock

2015-10-30 Thread Yang Shi
When running bpf samples on rt kernel, it reports the below warning: BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:917 in_atomic(): 1, irqs_disabled(): 128, pid: 477, name: ping Preemption disabled at:[] kprobe_perf_func+0x30/0x228 CPU: 3 PID: 477 Comm: ping Not