Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-02 Thread KP Singh
On Tue, Jun 2, 2020 at 10:13 AM Jiri Olsa wrote: > > On Mon, Jun 01, 2020 at 03:12:13PM -0700, Alexei Starovoitov wrote: > > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > > > Currenty lsm uses bpf_tracing_func_proto helpe

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-02 Thread Jiri Olsa
On Mon, Jun 01, 2020 at 03:12:13PM -0700, Alexei Starovoitov wrote: > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > not include stack trace or perf event output.

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Song Liu
On Mon, Jun 1, 2020 at 3:12 PM Alexei Starovoitov wrote: > > On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > > not include stack trace or perf event output. It's use

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Alexei Starovoitov
On Mon, Jun 1, 2020 at 12:00 PM Song Liu wrote: > > On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > > > Currenty lsm uses bpf_tracing_func_proto helpers which do > > not include stack trace or perf event output. It's useful > > to have those for bpftrace lsm support [1]. > > > > Using tracin

Re: [PATCH] bpf: Use tracing helpers for lsm programs

2020-06-01 Thread Song Liu
On Sun, May 31, 2020 at 8:45 AM Jiri Olsa wrote: > > Currenty lsm uses bpf_tracing_func_proto helpers which do > not include stack trace or perf event output. It's useful > to have those for bpftrace lsm support [1]. > > Using tracing_prog_func_proto helpers for lsm programs. How about using raw_

[PATCH] bpf: Use tracing helpers for lsm programs

2020-05-31 Thread Jiri Olsa
Currenty lsm uses bpf_tracing_func_proto helpers which do not include stack trace or perf event output. It's useful to have those for bpftrace lsm support [1]. Using tracing_prog_func_proto helpers for lsm programs. [1] https://github.com/iovisor/bpftrace/pull/1347 Cc: KP Singh Signed-off-by: J