Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-13 Thread Jay Vosburgh
David Miller wrote: >From: Jay Vosburgh >Date: Mon, 13 May 2019 09:43:30 -0700 > >> That would be my preference, as the 29c4948293bf commit looks to >> be the change actually being fixed. > >Sorry I pushed the original commit message out :-( > >But isn't the Fixes: tag he choose the one whe

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-13 Thread David Miller
From: Jarod Wilson Date: Fri, 10 May 2019 17:57:09 -0400 > There's currently a problem with toggling arp_validate on and off with an > active-backup bond. At the moment, you can start up a bond, like so: ... > The problem lies in bond_options.c, where passing in arp_validate=0 > results in bond-

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-13 Thread David Miller
From: Jay Vosburgh Date: Mon, 13 May 2019 09:43:30 -0700 > That would be my preference, as the 29c4948293bf commit looks to > be the change actually being fixed. Sorry I pushed the original commit message out :-( But isn't the Fixes: tag he choose the one where the logic actually causes p

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-13 Thread Jay Vosburgh
Jarod Wilson wrote: >On 5/10/19 6:53 PM, Jay Vosburgh wrote: >> Jarod Wilson wrote: >> >>> There's currently a problem with toggling arp_validate on and off with an >>> active-backup bond. At the moment, you can start up a bond, like so: >>> >>> modprobe bonding mode=1 arp_interval=100 arp_valid

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-10 Thread Jarod Wilson
On 5/10/19 6:53 PM, Jay Vosburgh wrote: Jarod Wilson wrote: There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=192.168.1.1 ip lin

Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-10 Thread Jay Vosburgh
Jarod Wilson wrote: >There's currently a problem with toggling arp_validate on and off with an >active-backup bond. At the moment, you can start up a bond, like so: > >modprobe bonding mode=1 arp_interval=100 arp_validate=0 >arp_ip_targets=192.168.1.1 >ip link set bond0 down >echo "ens4f0" > /sy

[PATCH] bonding: fix arp_validate toggling in active-backup mode

2019-05-10 Thread Jarod Wilson
There's currently a problem with toggling arp_validate on and off with an active-backup bond. At the moment, you can start up a bond, like so: modprobe bonding mode=1 arp_interval=100 arp_validate=0 arp_ip_targets=192.168.1.1 ip link set bond0 down echo "ens4f0" > /sys/class/net/bond0/bonding/sla