Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-14 Thread Larry Finger
Jean, Jean Tourrilhes wrote: I must admit that the original definition was too clever (or too ambiguous, or too original, take your pick). range->max_qual.level is always supposed to have a meaningfull value. People that did not understand that original definition just put 0 there, as i

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-14 Thread Jean Tourrilhes
On Thu, Jul 13, 2006 at 11:37:45PM -0400, Dan Williams wrote: > On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote: > > Dan Williams wrote: > > > > > > NAK... remember, range->max_qual.level must be _0_ if you're in dBm, > > > > I do not think this is right. From the comments in include/linux/

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-13 Thread Larry Finger
Dan Williams wrote: Jean, what's the official word on range->max_qual.level? I don't know where I came up with the requirement that max_qual.level must be 0 to indicate that the units are in dBm (as opposed to RSSI), but it might well have been because we had no way to detect RSSI vs. dBm befor

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-13 Thread Dan Williams
On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote: > Dan Williams wrote: > > > > NAK... remember, range->max_qual.level must be _0_ if you're in dBm, > > I do not think this is right. From the comments in include/linux/wireless.h: > > /* Quality of link & SNR stuff */ > /*

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-11 Thread Larry Finger
Dan Williams wrote: NAK... remember, range->max_qual.level must be _0_ if you're in dBm, I do not think this is right. From the comments in include/linux/wireless.h: /* Quality of link & SNR stuff */ /* Quality range (link, level, noise) * If the quality is absolute,

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-11 Thread Dan Williams
On Tue, 2006-07-11 at 11:04 -0500, Larry Finger wrote: > This minor patch adjusts the parameters of the wireless statistics to improve > the display of > programs such as the "Wireless Network Information" applet of KDE. > > Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> > > ==

[PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-11 Thread Larry Finger
This minor patch adjusts the parameters of the wireless statistics to improve the display of programs such as the "Wireless Network Information" applet of KDE. Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> == diff --git a/drivers/