Re: [PATCH] b44: fix laptop carrier detect

2006-01-22 Thread Stefan Rompf
Am Samstag 21 Januar 2006 19:48 schrieb Herbert Xu: > > Kind of odd that we don't have carrier=off by default.. > > If someone could have a look at all the drivers to see what might > break if we changed the default, then we might be able to change it. Actually all drivers that don't have carrier

Re: [PATCH] b44: fix laptop carrier detect

2006-01-21 Thread Herbert Xu
Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > > Kind of odd that we don't have carrier=off by default.. If someone could have a look at all the drivers to see what might break if we changed the default, then we might be able to change it. Cheers, -- Visit Openswan at http://www.openswan.org/ E

Re: [PATCH] b44: fix laptop carrier detect

2006-01-21 Thread Stefan Rompf
Am Samstag 21 Januar 2006 11:49 schrieb Lennert Buytenhek: > I ran into this problem with ixp2000 too. However, calling > netif_carrier_off calls into linkwatch_fire_event and I wasn't sure > whether this is the right thing to do when the netdev isn't even > registered yet. This is not the right

Re: [PATCH] b44: fix laptop carrier detect

2006-01-21 Thread Lennert Buytenhek
On Fri, Jan 20, 2006 at 09:13:17PM -0800, Stephen Hemminger wrote: > On my laptop, the b44 device is created and the carrier state defaults > to ON when created by alloc_etherdev. This means tools like NetworkManager > see the carrier as On and try and bring the device up. The correct thing > to

[PATCH] b44: fix laptop carrier detect

2006-01-20 Thread Stephen Hemminger
On my laptop, the b44 device is created and the carrier state defaults to ON when created by alloc_etherdev. This means tools like NetworkManager see the carrier as On and try and bring the device up. The correct thing to do is mark the carrier as Off when device is created. Signed-off-by: Stephe