Re: [PATCH] b43: fix memory leak

2016-03-10 Thread Sudip Mukherjee
On Thursday 10 March 2016 11:13 PM, Michael Büsch wrote: On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: https://patchwork.kernel.org/patch/8049041/ I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 [14e4:4311] (rev 01)". I will try to test it on this weekend.

Re: [PATCH] b43: fix memory leak

2016-03-10 Thread Michael Büsch
On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: > > https://patchwork.kernel.org/patch/8049041/ > > I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 > [14e4:4311] (rev 01)". > I will try to test it on this weekend. Any news on this one? -- Michael pgpLl72Z3

Re: [PATCH] b43: fix memory leak

2016-02-19 Thread Sudip Mukherjee
On Friday 19 February 2016 01:14 PM, Kalle Valo wrote: Michael Büsch writes: On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: From: Sudip Mukherjee On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee ---

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Kalle Valo
Michael Büsch writes: > On Thu, 18 Feb 2016 18:04:36 +0530 > Sudip Mukherjee wrote: > >> From: Sudip Mukherjee >> >> On error we jumped to the label bcma_out and returned the error code but >> we missed freeing dev. >> >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/net/wireless/broadco

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Michael Büsch
On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. > > Signed-off-by: Sudip Mukherjee > --- > drivers/net/wireless/broadcom/b43/main.c | 1 + > 1 file changed,

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Rafał Miłecki
On 18 February 2016 at 13:34, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and mayb

[PATCH] b43: fix memory leak

2016-02-18 Thread Sudip Mukherjee
From: Sudip Mukherjee On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/broadcom/b43/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/driv