Re: [PATCH] atm: clean up vcc_seq_next()

2019-02-16 Thread David Miller
From: Dan Carpenter Date: Thu, 14 Feb 2019 09:56:35 +0300 > It's confusing to call PTR_ERR(v). The PTR_ERR() function is basically > a fancy cast to long so it makes you wonder, was IS_ERR() intended? But > that doesn't make sense because vcc_walk() doesn't return error > pointers. > > This pa

[PATCH] atm: clean up vcc_seq_next()

2019-02-13 Thread Dan Carpenter
It's confusing to call PTR_ERR(v). The PTR_ERR() function is basically a fancy cast to long so it makes you wonder, was IS_ERR() intended? But that doesn't make sense because vcc_walk() doesn't return error pointers. This patch doesn't affect runtime, it's just a cleanup. Signed-off-by: Dan Car