Re: [PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread Florian Fainelli
On 7/7/2020 12:01 PM, Shyam Sundar S K wrote: > > On 7/7/2020 11:25 PM, Andrew Lunn wrote: >> [CAUTION: External Email] >> >> On Tue, Jul 07, 2020 at 05:32:54PM +, Shyam Sundar S K wrote: >>> In embedded environments, ethtool may not be available to toggle between >>> auto negotiation on/of

Re: [PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread David Miller
From: Shyam Sundar S K Date: Wed, 8 Jul 2020 00:31:25 +0530 > Agree to your feedback. Most of the information required to control > the connection is already present in the > > driver and this piece of information is missing. Customers who run a > minimal Linux do not have the flexibility This

Re: [PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread Shyam Sundar S K
On 7/7/2020 11:25 PM, Andrew Lunn wrote: [CAUTION: External Email] On Tue, Jul 07, 2020 at 05:32:54PM +, Shyam Sundar S K wrote: In embedded environments, ethtool may not be available to toggle between auto negotiation on/off. Add a module parameter to control auto negotiation for these

Re: [PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread Andrew Lunn
On Tue, Jul 07, 2020 at 05:32:54PM +, Shyam Sundar S K wrote: > In embedded environments, ethtool may not be available to toggle between > auto negotiation on/off. > > Add a module parameter to control auto negotiation for these situations. Where does this end? You can set the link speed via

[PATCH] amd-xgbe: add module param for auto negotiation

2020-07-07 Thread Shyam Sundar S K
In embedded environments, ethtool may not be available to toggle between auto negotiation on/off. Add a module parameter to control auto negotiation for these situations. Signed-off-by: Shyam Sundar S K --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 28 +++-- 1 file changed,