Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-10 Thread Robert Schulze
Hi, I regret making a mistake yesterday, I forgot a comma. Here now is the working patch. [PATCH] airo: collapse debugging-messages in issuecommand to one line Robert Schulze --- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08 14:02:12.0 +0200 +++ linux-2.6.17.1/driver

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Dan Williams
On Mon, 2006-07-10 at 00:23 +0200, Robert Schulze wrote: > Hi, > > ok lets keep that message to be visible to anybody, but put it into one line. > Thanks for your comments. > Now, I will track down what causes the error on my machine, I think it has > something todo with pcmcia... Looks good. T

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Robert Schulze
Hi, ok lets keep that message to be visible to anybody, but put it into one line. Thanks for your comments. Now, I will track down what causes the error on my machine, I think it has something todo with pcmcia... with kind regards, Robert Schulze --- linux-2.6.17.1/drivers/net/wireless/airo.c

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Michael Tokarev
Robert Schulze wrote: > Hi, > > Dan Williams schrieb: >> This message will only happen if the card hangs up and stops responding >> to commands anyway, so we don't necessarily care about making the >> message decipherable to anyone other than developers. > > Well, I get this message each time I i

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Robert Schulze
Hi, Dan Williams schrieb: > This message will only happen if the card hangs up and stops responding > to commands anyway, so we don't necessarily care about making the > message decipherable to anyone other than developers. Well, I get this message each time I insert my Cisco Aironet 350 PCMCIA

Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-09 Thread Dan Williams
On Sat, 2006-07-08 at 17:59 +0200, Robert Schulze wrote: > I don't think that messages like > > airo(eth1): cmd= 111 > > airo(eth1): status= 7f11 > > airo(eth1): Rsp0= 2 > > airo(eth1): Rsp1= 0 > > airo(eth1): Rsp2= 0 > > are interesting to normal users, so switch them from airo_print_err() t

[PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-08 Thread Robert Schulze
I don't think that messages like airo(eth1): cmd= 111 airo(eth1): status= 7f11 airo(eth1): Rsp0= 2 airo(eth1): Rsp1= 0 airo(eth1): Rsp2= 0 are interesting to normal users, so switch them from airo_print_err() to airo_print_dbg(). Furthermore, remove implicit linefeed in those messages, as t