Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Thomas Graf
* Harald Welte <[EMAIL PROTECTED]> 2005-08-07 17:03 > On Sun, Aug 07, 2005 at 01:20:39PM +0200, Thomas Graf wrote: > > Same very minor issues as nfnetlink regarding some of the > > new netlink message construction policies. I'll "fix" them > > during the conversion to the generic netlink attributes

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 01:20:39PM +0200, Thomas Graf wrote: > * Harald Welte <[EMAIL PROTECTED]> 2005-07-30 12:30 > > This (long-awaited) patch adds the generic nfnetlink-based userspace > > logging. nfnetlink_log can be used for any protocol family, and > > supports upt to 65535 logging groups (

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Thomas Graf
* Harald Welte <[EMAIL PROTECTED]> 2005-07-30 12:30 > This (long-awaited) patch adds the generic nfnetlink-based userspace > logging. nfnetlink_log can be used for any protocol family, and > supports upt to 65535 logging groups (that could go to separate logging > daemons, e.g.). Same very minor

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Harald Welte
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote: > From: Harald Welte <[EMAIL PROTECTED]> > Date: Thu, 4 Aug 2005 00:03:53 +0200 > > > However, all nfnetlink-based protocols are supposed to be both endian > > and 32/64 as well as alignment (*) safe. the protocol definitions > > a

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Andi Kleen
> Unless I'm overlooking something, to the best of my knowledge I don't > think we could still run into any trouble here. Still risky. Here's a different idea. Define a new aligned u64 type and use that on i386 too. Like /* Must be #define because __attribute__ doesn't work on typedefs */ #defi

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Harald Welte
On Thu, Aug 04, 2005 at 06:50:42AM -0700, David S. Miller wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Subject: Re: [PATCH] add new nfnetlink_log subsystem > Date: Thu, 4 Aug 2005 00:19:41 +0200 > > > > no, it hasn't. I am travelling and don't h

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Andi Kleen
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote: > From: Harald Welte <[EMAIL PROTECTED]> > Date: Thu, 4 Aug 2005 00:03:53 +0200 > > > However, all nfnetlink-based protocols are supposed to be both endian > > and 32/64 as well as alignment (*) safe. the protocol definitions > > a

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Subject: Re: [PATCH] add new nfnetlink_log subsystem Date: Thu, 4 Aug 2005 00:19:41 +0200 > > no, it hasn't. I am travelling and don't have the space for a > > debian/i386 installation in addition to the debian/x86_64 on this

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 4 Aug 2005 00:03:53 +0200 > However, all nfnetlink-based protocols are supposed to be both endian > and 32/64 as well as alignment (*) safe. the protocol definitions > always use u_intXX_t types, all network byte order, and no kernel pointers > p

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-03 Thread Andi Kleen
> no, it hasn't. I am travelling and don't have the space for a > debian/i386 installation in addition to the debian/x86_64 on this box, > sorry :( That sounds risky. I would ask for this stuff not being merged before it isn't tested. > However, all nfnetlink-based protocols are supposed to be b

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-03 Thread Harald Welte
On Wed, Aug 03, 2005 at 10:02:28PM +0200, Andi Kleen wrote: > Harald Welte <[EMAIL PROTECTED]> writes: > > > Hi Dave! > > > > This (long-awaited) patch adds the generic nfnetlink-based userspace > > logging. nfnetlink_log can be used for any protocol family, and > > supports upt to 65535 logging

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-03 Thread Andi Kleen
Harald Welte <[EMAIL PROTECTED]> writes: > Hi Dave! > > This (long-awaited) patch adds the generic nfnetlink-based userspace > logging. nfnetlink_log can be used for any protocol family, and > supports upt to 65535 logging groups (that could go to separate logging > daemons, e.g.). Hi - I hope

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-02 Thread Harald Welte
Hi Acme! On Mon, Aug 01, 2005 at 09:54:47PM -0300, Arnaldo Carvalho de Melo wrote: > > Are you aware of this one? :-) Perhaps Dave commited some mistake > > while merging, this is on 2.6.14.git latest. > > Ah, this is with 'make allyesconfig'. Dave's tree is missing the attached patch. -- - H

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-02 Thread Harald Welte
On Mon, Aug 01, 2005 at 09:54:47PM -0300, Arnaldo Carvalho de Melo wrote: > On 8/1/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > > CC net/netfilter/nfnetlink_queue.o > > net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': > > net/netfilter/nfnetlink_queue.c:1030: erro

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-01 Thread Arnaldo Carvalho de Melo
On 8/1/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > CC net/netfilter/nfnetlink_queue.o > net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': > net/netfilter/nfnetlink_queue.c:1030: error: `proc_net_netfilter' > undeclared (first use in this function) > net/netfilter/

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-01 Thread Arnaldo Carvalho de Melo
CC net/netfilter/nfnetlink_queue.o net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': net/netfilter/nfnetlink_queue.c:1030: error: `proc_net_netfilter' undeclared (first use in this function) net/netfilter/nfnetlink_queue.c:1030: error: (Each undeclared identifier is reported on

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-31 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 30 Jul 2005 19:33:15 +0200 > [NETFILTER] add proc_net_remove() to nfnetlink_queue and nfnetlink_log > > Also fixes a typo inside a comment. > Thanks to Sven Schuster <[EMAIL PROTECTED]> > > Signed-off-by: Harald Welte <[EMAIL PROTECTED]> Applied

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-31 Thread Harald Welte
Thanks for your comments, Sven. Dave: Please apply the attached patch on top of all other patches I sent you. It also fixes the same bug in nfnetlink_queue. Thanks! -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ ===

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-30 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 30 Jul 2005 12:30:05 +0200 > This (long-awaited) patch adds the generic nfnetlink-based userspace > logging. nfnetlink_log can be used for any protocol family, and > supports upt to 65535 logging groups (that could go to separate logging > daemons

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-30 Thread Sven Schuster
Hi Harald, On Sat, Jul 30, 2005 at 12:30:05PM +0200, Harald Welte told us: > diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c > new file mode 100644 > --- /dev/null > +++ b/net/netfilter/nfnetlink_log.c > @@ -0,0 +1,992 @@ ... > +static struct sk_buff *nfulnl_alloc_skb(u

[PATCH] add new nfnetlink_log subsystem

2005-07-30 Thread Harald Welte
Hi Dave! This (long-awaited) patch adds the generic nfnetlink-based userspace logging. nfnetlink_log can be used for any protocol family, and supports upt to 65535 logging groups (that could go to separate logging daemons, e.g.). The patch is incremental to my nf_log update in <[EMAIL PROTECTED]