Re: [PATCH] Update pptp handling to avoid null pointer deref. v2

2017-01-02 Thread David Miller
From: Ian Kumlien Date: Mon, 2 Jan 2017 09:18:35 +0100 > __skb_flow_dissect can be called with a skb or a data packet, either > can be NULL. All calls seems to have been moved to __skb_header_pointer > except the pptp handling which is still calling skb_header_pointer. ... > Fixes: ab10dccb1160

[PATCH] Update pptp handling to avoid null pointer deref. v2

2017-01-02 Thread Ian Kumlien
__skb_flow_dissect can be called with a skb or a data packet, either can be NULL. All calls seems to have been moved to __skb_header_pointer except the pptp handling which is still calling skb_header_pointer. skb_header_pointer will use skb->data and thus: [ 109.556866] BUG: unable to handle kern

Re: [PATCH] Update pptp handling to avoid null pointer deref.

2017-01-02 Thread Ian Kumlien
On Mon, Jan 2, 2017 at 5:07 AM, David Miller wrote: > From: Ian Kumlien > Date: Mon, 2 Jan 2017 00:19:36 +0100 > >> __skb_flow_dissect can be called with a skb or a data packet, either >> can be NULL. All calls seems to have been moved to __skb_header_pointer >> except the pptp handling which is

Re: [PATCH] Update pptp handling to avoid null pointer deref.

2017-01-01 Thread David Miller
From: Ian Kumlien Date: Mon, 2 Jan 2017 00:19:36 +0100 > __skb_flow_dissect can be called with a skb or a data packet, either > can be NULL. All calls seems to have been moved to __skb_header_pointer > except the pptp handling which is still calling skb_header_pointer. > > skb_header_pointer wi

[PATCH] Update pptp handling to avoid null pointer deref.

2017-01-01 Thread Ian Kumlien
__skb_flow_dissect can be called with a skb or a data packet, either can be NULL. All calls seems to have been moved to __skb_header_pointer except the pptp handling which is still calling skb_header_pointer. skb_header_pointer will use skb->data and thus: [ 109.556866] BUG: unable to handle kern