Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-30 Thread Satyam Sharma
On Mon, 30 Jul 2007, Petko Manolov wrote: > On Sun, 29 Jul 2007, Oliver Neukum wrote: > > > [...] > > pegasus == NULL there would be a kernel bug. Silently ignoring > > it, like the code now wants to do is bad. As the oops has never been > > reported, I figure turning it into an explicit debugg

Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-30 Thread Petko Manolov
On Sun, 29 Jul 2007, Oliver Neukum wrote: Am Sonntag 29 Juli 2007 schrieb Jesper Juhl: On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: Hi, On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: Hello, This patch makes sure we don't dereference a NULL pointer in drivers/net/usb/pegasus.c::

Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-29 Thread Satyam Sharma
On Sun, 29 Jul 2007, Oliver Neukum wrote: > Am Sonntag 29 Juli 2007 schrieb Jesper Juhl: > > On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > > > On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > > Hello, > > > > > > > > This patch makes sure we don't dereference a

Re: [linux-usb-devel] [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-29 Thread Oliver Neukum
Am Sonntag 29 Juli 2007 schrieb Jesper Juhl: > On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > Hi, > > > > On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > > > This patch makes sure we don't dereference a NULL pointer in > > > drivers/net/usb/pegasus.c::write_bulk_c

Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-28 Thread Jesper Juhl
On 29/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Hi, > > On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > Hello, > > > > This patch makes sure we don't dereference a NULL pointer in > > drivers/net/usb/pegasus.c::write_bulk_callback() in the initial > > struct net_device *net = pegasus

Re: [PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-28 Thread Satyam Sharma
Hi, On 7/29/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > Hello, > > This patch makes sure we don't dereference a NULL pointer in > drivers/net/usb/pegasus.c::write_bulk_callback() in the initial > struct net_device *net = pegasus->net; assignment. > The existing code checks if 'pegasus' is NULL an

[PATCH] USB Pegasus driver - avoid a potential NULL pointer dereference.

2007-07-28 Thread Jesper Juhl
Hello, This patch makes sure we don't dereference a NULL pointer in drivers/net/usb/pegasus.c::write_bulk_callback() in the initial struct net_device *net = pegasus->net; assignment. The existing code checks if 'pegasus' is NULL and bails out if it is, so we better not touch that pointer until