Re: [PATCH] Signed-off-by: giladreti

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 8:06 AM Gilad Reti wrote: > > On Mon, Jan 11, 2021, 17:55 Daniel Borkmann wrote: > > > > Hello Gilad, > > > > On 1/11/21 4:31 PM, giladreti wrote: > > > Added support for pointer to mem register spilling, to allow the verifier > > > to track pointer to valid memory address

Re: [PATCH] Signed-off-by: giladreti

2021-01-11 Thread Gilad Reti
On Mon, Jan 11, 2021, 17:55 Daniel Borkmann wrote: > > Hello Gilad, > > On 1/11/21 4:31 PM, giladreti wrote: > > Added support for pointer to mem register spilling, to allow the verifier > > to track pointer to valid memory addresses. Such pointers are returned > > for example by a successful call

Re: [PATCH] Signed-off-by: giladreti

2021-01-11 Thread Daniel Borkmann
Hello Gilad, On 1/11/21 4:31 PM, giladreti wrote: Added support for pointer to mem register spilling, to allow the verifier to track pointer to valid memory addresses. Such pointers are returned for example by a successful call of the bpf_ringbuf_reserve helper. This patch was suggested as a so

Re: [PATCH] Signed-off-by: giladreti

2021-01-11 Thread Marek BehĂșn
The Signed-off-by line should be last in the commit message, not first. First line (which becomes e-mail subject) should describe what the commit does (in a short one liner) and where it does it. So for your patch it could be something like bpf: support pointer to mem register spilling in verifi

[PATCH] Signed-off-by: giladreti

2021-01-11 Thread giladreti
Added support for pointer to mem register spilling, to allow the verifier to track pointer to valid memory addresses. Such pointers are returned for example by a successful call of the bpf_ringbuf_reserve helper. This patch was suggested as a solution by Yonghong Song. --- kernel/bpf/verifier.c |