Re: [PATCH] Remove duplicated code from ipw2200.c

2006-03-17 Thread John W. Linville
On Tue, Feb 28, 2006 at 09:48:28AM -0600, Larry Finger wrote: > As stated in a comment, the ipw2200 driver uses several routines that were > borrowed from ieee80211_geo.c. As ipw2200 requires ieee80211, these > routines are duplicated. The attached patch, which is sent as an attachment > to pres

Re: [PATCH] Remove duplicated code from ipw2200.c

2006-02-28 Thread Larry Finger
Pete Zaitcev wrote: Looks good to me, though I only made a cursory glance to verify that routines are indeed identical. -- Pete The only difference is in the test near the beginning of ieee80211_is_valid_channel where the IEEE80211_CH_INVALID flag is tested, whereas it was not in the ipw2200

Re: [PATCH] Remove duplicated code from ipw2200.c

2006-02-28 Thread Pete Zaitcev
On Tue, 28 Feb 2006 09:48:28 -0600, Larry Finger <[EMAIL PROTECTED]> wrote: > As stated in a comment, the ipw2200 driver uses several routines that were > borrowed > from ieee80211_geo.c. > Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> Looks good to me, though I only made a cursory glance to

[PATCH] Remove duplicated code from ipw2200.c

2006-02-28 Thread Larry Finger
As stated in a comment, the ipw2200 driver uses several routines that were borrowed from ieee80211_geo.c. As ipw2200 requires ieee80211, these routines are duplicated. The attached patch, which is sent as an attachment to preserve whitespace, converts ipw2200.c to use the ieee80211 versions, the