Re: [PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-13 Thread Paul Janzen
"Dale Farnsworth" <[EMAIL PROTECTED]> writes: >> +if (has_tiny_unaligned_frags(skb)) { >> +if ((skb_linearize(skb, GFP_ATOMIC) != 0) >> +|| has_tiny_unaligned_frags(skb)) { > > There is no way that skb_linearize can return without removing all frags >

Re: [PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-13 Thread Dale Farnsworth
On Mon, Jan 09, 2006 at 04:43:08AM +, Paul Janzen wrote: > Paul Janzen <[EMAIL PROTECTED]> writes: > > In mv643xx_eth_start_xmit: > > [...] > > spin_lock_irqsave(&mp->lock, flags); > > [...] > > /* Since hardware can't handle unaligned fragments smaller > > * than 9

[PATCH] Re: mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-08 Thread Paul Janzen
Paul Janzen <[EMAIL PROTECTED]> writes: > In mv643xx_eth_start_xmit: > [...] > spin_lock_irqsave(&mp->lock, flags); > [...] > /* Since hardware can't handle unaligned fragments smaller >* than 9 bytes, if we find any, we linearize the skb >* and