Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Santosh Shilimkar
On 1/22/2018 2:17 PM, Kees Cook wrote: On Tue, Jan 23, 2018 at 4:01 AM, Santosh Shilimkar wrote: On 1/22/2018 3:24 AM, Kees Cook wrote: As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an IPoIB interface to itself causes

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Kees Cook
On Tue, Jan 23, 2018 at 4:01 AM, Santosh Shilimkar wrote: > On 1/22/2018 3:24 AM, Kees Cook wrote: >> >> As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 >> >> Attempting an RDS connection from the IP address of an IPoIB interface >> to itself causes a kernel panic due to a BUG_

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Santosh Shilimkar
On 1/22/2018 7:47 AM, David Miller wrote: From: Leon Romanovsky Date: Mon, 22 Jan 2018 17:10:54 +0200 On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c index 8557a1cae041..5fbf635d17cb 100644 --- a/net/rds/ib_send.c +++ b/net/rds/ib_

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Santosh Shilimkar
On 1/22/2018 3:24 AM, Kees Cook wrote: As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread David Miller
From: Leon Romanovsky Date: Mon, 22 Jan 2018 17:10:54 +0200 > On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: >> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c >> index 8557a1cae041..5fbf635d17cb 100644 >> --- a/net/rds/ib_send.c >> +++ b/net/rds/ib_send.c >> @@ -506,7 +506,7 @@ in

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Leon Romanovsky
On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: > As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 > > Attempting an RDS connection from the IP address of an IPoIB interface > to itself causes a kernel panic due to a BUG_ON() being triggered. > Making the test less str

[PATCH] RDS: Fix rds-ping inducing kernel panic

2018-01-22 Thread Kees Cook
As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine. A local u