Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

2007-12-21 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:39:36 +0300 > David Miller wrote: > > What introduced this bug? This code didn't have this > > problem previously. > > commit cd40b7d3983c708aabe3d3008ec64ffce56d33b0 > Author: Denis V. Lunev <[EMAIL PROTECTED]> > Date: Wed O

Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

2007-12-21 Thread Denis V. Lunev
David Miller wrote: > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 12:00:43 +0300 > >> nl_fib_input re-reuses incoming skb to send the reply. This means that this >> packet will be freed twice, namely in: >> - netlink_unicast_kernel >> - on receive path >> Use clone to send

Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

2007-12-21 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:00:43 +0300 > nl_fib_input re-reuses incoming skb to send the reply. This means that this > packet will be freed twice, namely in: > - netlink_unicast_kernel > - on receive path > Use clone to send as a cure, the caller is respon

[PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

2007-12-21 Thread Denis V. Lunev
nl_fib_input re-reuses incoming skb to send the reply. This means that this packet will be freed twice, namely in: - netlink_unicast_kernel - on receive path Use clone to send as a cure, the caller is responsible for kfree_skb on error. Thanks to Alexey Dobryan, who originally found the problem.