> 200 checkpatch changes in one commit?
>
> imo it makes sense to fix coding style only if nearby lines are
> affected by meaningful changes.
> Just blank rewrites like these are more harmful than useful.
> They distort git blame, make backporting harder, etc.
I'll keep that in mind, thank you.
> From: Krzysztof Majzerowicz-Jaszcz
> Date: Tue, 15 Sep 2015 20:36:29 +0200
>
>> OK, sorry. I'll undo the comments then. Do you have any other
>> suggestions?
>
> I think even the non-comment changes make the code look less nice.
>
> Why don't you just pass on these cleanups for now? Thanks.
From: Alexei Starovoitov
Date: Tue, 15 Sep 2015 11:43:49 -0700
> imo it makes sense to fix coding style only if nearby lines are
> affected by meaningful changes.
> Just blank rewrites like these are more harmful than useful.
> They distort git blame, make backporting harder, etc.
+1
--
To unsub
From: Krzysztof Majzerowicz-Jaszcz
Date: Tue, 15 Sep 2015 20:36:29 +0200
> OK, sorry. I'll undo the comments then. Do you have any other
> suggestions?
I think even the non-comment changes make the code look less nice.
Why don't you just pass on these cleanups for now? Thanks.
--
To unsubscrib
On Tue, Sep 15, 2015 at 08:36:29PM +0200, Krzysztof Majzerowicz-Jaszcz wrote:
> OK, sorry. I'll undo the comments then. Do you have any other suggestions?
>
> KMJ
>
> On 15/09/15 20:22, Eric W. Biederman wrote:
> > Krzysztof Majzerowicz-Jaszcz writes:
> >
> >> Fixed most coding style issues rep
OK, sorry. I'll undo the comments then. Do you have any other suggestions?
KMJ
On 15/09/15 20:22, Eric W. Biederman wrote:
> Krzysztof Majzerowicz-Jaszcz writes:
>
>> Fixed most coding style issues reported by checkpatch.pl
>
> Ugh. At least in the matter of comments I find this patch makes
>
Krzysztof Majzerowicz-Jaszcz writes:
> Fixed most coding style issues reported by checkpatch.pl
Ugh. At least in the matter of comments I find this patch makes
the code uglier.
Replacing:
/*
* Important banner about the code
*/
with
/* Important banner about the code */
Does n
Fixed most coding style issues reported by checkpatch.pl
Signed-off-by: Krzysztof Majzerowicz-Jaszcz
---
net/core/sock.c | 442 +---
1 file changed, 200 insertions(+), 242 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index ca298
