Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-05 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 05 Mar 2007 09:21:30 +0100 > I dont know very much this compat stuff, but I found > compat_sock_get_timestamp() only called from net/x25/af_x25.c Good point, I thought for some reason that this function was used for all SO_TIMESTAMP handling, but

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-05 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 05 Mar 2007 08:40:03 +0100 Here is the second version of this patch, including missing bits spoted by Stephen. This is against net-2.6.22 Applied, thanks a lot. Note : this patch includes a bug correction in compat_soc

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-05 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 05 Mar 2007 08:40:03 +0100 > Here is the second version of this patch, including missing bits spoted by > Stephen. This is against net-2.6.22 Applied, thanks a lot. > Note : this patch includes a bug correction in compat_sock_get_timestamp() > w

[PATCH] NET : convert network timestamps to ktime_t

2007-03-04 Thread Eric Dumazet
Hi David Here is the second version of this patch, including missing bits spoted by Stephen. This is against net-2.6.22 Thank you [PATCH] NET : convert network timestamps to ktime_t We currently use a special structure (struct skb_timeval) and plain 'struct timeval' to st

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-04 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 02 Mar 2007 23:46:14 +0100 Stephen Hemminger a écrit : You missed a couple of spots. Arg yes... ... - } - skb_get_timestamp(skb, &svsk->sk_sk->sk_stamp); + svsk->sk_sk->sk_stamp = (skb->tstamp.tv64 !

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-04 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 02 Mar 2007 23:46:14 +0100 > Stephen Hemminger a écrit : > > You missed a couple of spots. > > Arg yes... ... > > - } > > - skb_get_timestamp(skb, &svsk->sk_sk->sk_stamp); > > + svsk->sk_sk->sk_stamp = (skb->tstamp.tv64 != 0) ? skb->tstamp

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-02 Thread Eric Dumazet
Stephen Hemminger a écrit : On Fri, 2 Mar 2007 15:38:41 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: We currently use a special structure (struct skb_timeval) and plain 'struct timeval' to store packet timestamps in sk_buffs and struct sock. This has some drawbacks : - Fixed resolution of mi

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-02 Thread Stephen Hemminger
On Fri, 2 Mar 2007 15:38:41 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > We currently use a special structure (struct skb_timeval) and plain 'struct > timeval' to store packet timestamps in sk_buffs and struct sock. > > This has some drawbacks : > - Fixed resolution of micro second. > - Waste

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-02 Thread Stephen Hemminger
On Fri, 2 Mar 2007 15:38:41 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > We currently use a special structure (struct skb_timeval) and plain 'struct > timeval' to store packet timestamps in sk_buffs and struct sock. > > This has some drawbacks : > - Fixed resolution of micro second. > - Waste

[PATCH] NET : convert network timestamps to ktime_t

2007-03-02 Thread Eric Dumazet
We currently use a special structure (struct skb_timeval) and plain 'struct timeval' to store packet timestamps in sk_buffs and struct sock. This has some drawbacks : - Fixed resolution of micro second. - Waste of space on 64bit platforms where sizeof(struct timeval)=16 I suggest using ktime_t t